[Webkit-unassigned] [Bug 103261] New: [Qt][EFL][WK2] Repaint counter not working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103261

           Summary: [Qt][EFL][WK2] Repaint counter not working
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kenneth at webkit.org
                CC: noam at webkit.org, demarchi at webkit.org,
                    tmpsantos at gmail.com, zeno at webkit.org


when running with [QT_]WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS=1 a repaint counter is shown.

This shown 1, then next time 10, then next time 100, etc... This is because it cannot reuse texture between 1 and 10 and 100 and 1000, etc.

The following fixes it, but something must be wrong with the texture pool, or elsewhere.

--- a/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
+++ b/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
@@ -376,7 +376,8 @@ void TextureMapperGL::drawRepaintCounter(int value, int pointSize, const FloatPo
     IntRect sourceRect(IntPoint::zero(), size);
     IntRect targetRect(roundedIntPoint(targetPoint), size);

-    RefPtr<BitmapTexture> texture = acquireTextureFromPool(size);
+    RefPtr<BitmapTexture> texture = createTexture();
+    texture->reset(size);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.