[Webkit-unassigned] [Bug 98857] [Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98857


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175969|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #20 from Zoltan Herczeg <zherczeg at webkit.org>  2012-11-26 05:35:16 PST ---
(From update of attachment 175969)
Thanks for the fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=175969&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:816
> +        ARMWord tmp = (static_cast<unsigned>(imm.m_value) == 0x80000000) ? ARMAssembler::InvalidImmediate : m_assembler.getOp2(-imm.m_value);
> +        if (tmp != ARMAssembler::InvalidImmediate)
> +            m_assembler.cmn(reg, tmp);
> +        else
> +            m_assembler.cmp(reg, m_assembler.getImm(imm.m_value, ARMRegisters::S0));

Please move this code duplication to a common subfunction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.