[Webkit-unassigned] [Bug 86678] Inconsistency in FrameView::forceLayoutForPagination and FrameView::forceLayout.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86678





--- Comment #9 from Brent Fulgham <bfulgham at webkit.org>  2012-11-25 20:57:53 PST ---
(From update of attachment 143396)
View in context: https://bugs.webkit.org/attachment.cgi?id=143396&action=review

I think this change looks good. I'm curious if the two methods are ever used in isolation such that there actually does need this additional parameter?

It sounds like the answer is no, and therefore this simplification is a great change.

Can you confirm this, and I will r+ the patch so it can be landed?

> Source/WebCore/ChangeLog:7
> +

You should add the helpful text from your bug report: "
FrameView::forceLayoutForPagination calls adjustViewSize internally, while forceLayout does not. However, every call to forceLayout (near forceLayoutForPagination) is paired with a call to adjustViewSize. Make the two calls consistent."

> Source/WebKit/mac/WebView/WebHTMLView.mm:-3059
> -            coreView->forceLayoutForPagination(pageSize, originalPageSize, maximumShrinkRatio, adjustViewSize ? AdjustViewSize : DoNotAdjustViewSize);

Is the forceLayoutForPagination method ever called without a nearby call to forceLayout?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.