[Webkit-unassigned] [Bug 103207] New: Be consistent in handling of *Image::frameAtIndex (and related) return values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103207

           Summary: Be consistent in handling of *Image::frameAtIndex (and
                    related) return values
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bfulgham at webkit.org


Under certain conditions, the various image object "frameAtIndex" methods return null.  This means that 'nativeImageForCurrentFrame" can also return null.

This has resulted in a set of patches to ImageSVG (Bug 14531), BitmapImage (Bug 68753), ImageCG (Bug 61684), GraphicsLayerChromium (Bug 98456) and others (Bug 39797) to deal with the null return.

A number of classes check for null return and exit early (ImageWx.cpp, parts of ImageWinCE.cpp, ImageSkia.cpp, ImageCairoWin.cpp, ImageQt.cpp, ImageMac.mm, BitmapImageCG.cpp, BitmapImageCairo.cpp)

However, several others take the return value and use without validating (ImageCGWin.cpp, ImageCairoWin.cpp, parts of ImageWinCE.cpp)

This bug applies the same null checking used elsewhere in the codebase to these missed locations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.