[Webkit-unassigned] [Bug 103194] [GTK] Broken build with undefined references to shm_open / shm_unlink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103194





--- Comment #3 from Kalev Lember <kalevlember at gmail.com>  2012-11-25 09:00:29 PST ---
AC_CHECK_LIB and AC_SEARCH_LIBS write the result to the LIBS variable and I didn't want to clobber the contents of the variable here. I'm using save_LIBS to restore the original LIBS after calling AC_SEARCH_LIBS(). Perhaps it doesn't make much of a difference right here and right now, but it can avoid surprises in the future.

I guess the macros were written with small build systems in mind where only one LIBS variable is sufficient; in webkitgtk with several libraries and executables produced, it seems better to avoid using the global LIBS variable.

For what it's worth, cairo does the same thing with save_LIBS: http://cgit.freedesktop.org/cairo/tree/configure.ac#n796

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.