[Webkit-unassigned] [Bug 103175] Make renderer construction less generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103175





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2012-11-25 08:58:56 PST ---
> > Source/WebCore/dom/Text.cpp:311
> > +    if (!textRenderer || !textRendererIsNeeded(NodeRenderingContext(this, textRenderer->style()))) {
> > +        reattach();
> 
> I'm slightly confused by this re-attach here.

The change in text content may change the result of textRendererIsNeeded, requiring either addition or removal of the renderer. More optimal version would check if the change actually had such impact before reattaching. I suppose it has not been a real world problem so far.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.