[Webkit-unassigned] [Bug 101349] [GStreamer] Floating reference handling fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101349


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175872|review?                     |review-
               Flag|                            |




--- Comment #18 from Philippe Normand <pnormand at igalia.com>  2012-11-25 03:19:05 PST ---
(From update of attachment 175872)
View in context: https://bugs.webkit.org/attachment.cgi?id=175872&action=review

Awesome, thanks Thiago! Now just the ChangeLog to fix up and the missing include to add!

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:181
> +    priv->sourcePad = webkitGstGhostPadFromStaticTemplate(&srcTemplate, "src", 0);

GStreamerVersioning.h include is missing I think. BTW this code is not yet enabled by default in the build, you need to use the --web-audio build-webkit option. I have a patch almost ready for the 1.0 port to upload soon :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.