[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #36 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-23 04:48:36 PST ---
(From update of attachment 175781)
View in context: https://bugs.webkit.org/attachment.cgi?id=175781&action=review

Commented before but I'm reiterating so that my comments appears in the patch being reviewed.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
> +        for (size_t i = 0; i < workItemQueue.size(); ++i) {

Common practice in WebKit is to cache container size before the loop.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:86
> +            Function<void()> function = workItemQueue[i];

Useless temporary variable, we try to avoid those in WebKit. In this case, it is even worse because it is constructed before the isValid check.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:93
> +            function();

workItemQueue[i]();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.