[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #27 from Jongseok Yang <js45.yang at samsung.com>  2012-11-23 03:39:10 PST ---
(In reply to comment #26)
> (From update of attachment 175761 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175761&action=review
> 
> >>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
> >>> +        for (size_t i = 0; i < workItemQueue.size(); ++i) {
> >> 
> >> Please cache workItemQueue.size() before the loop.
> > 
> > Could you explain why it is required?
> 
> This is WebKit coding style and this makes sure that the queue size is not retrieved (possibly computed) for every iteration of the loop.

Is it WebKit coding style? There are so many uses like the style in WebKit.


> 
> >>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:-179
> >>> -        workQueue->performTimerWork();
> >> 
> >> Why is this removed?
> > 
> > This function need not be called when m_isValid is false.
> > So, I inserted this function into performWork().
> 
> I see now. I did not see that you moved it. However, moving it has side effects.
> With your change, performTimerWork() will not be called if m_workItemQueue is empty. Please make sure this is really what we want.

Thanks for your comment. But I cannot assume the issue.
WorkQueue::platformInvalidate() is called when trying to delete WorkQueue. At that time, the work for the items in queue is not required any more.
Even WorkQueue::platformInvalidate() in WorkQueueMac.cpp deletes m_dispatchQueue which has the dispatched items.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.