[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 23 03:13:12 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #24 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-23 03:15:16 PST ---
(From update of attachment 175766)
View in context: https://bugs.webkit.org/attachment.cgi?id=175766&action=review

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
> +        for (size_t i = 0; i < workItemQueue.size(); ++i) {

Please cache workItemQueue.size() before the loop

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:86
> +            Function<void()> function = workItemQueue[i];

Useless variable.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:93
> +            function();

workItemQueue[i](); ?

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:-179
> -        workQueue->performTimerWork();

Why is this removed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list