[Webkit-unassigned] [Bug 99829] OpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99829





--- Comment #18 from Zoltan Herczeg <zherczeg at webkit.org>  2012-11-23 01:36:16 PST ---
You have some good ideas.

> These look like they don't account for the possibility that the kernel will > fail to build. If the build fails, you'll be setting arguments / trying to > run a null kernel

The source code of the kernel should be correct, so the only fail possibility here is the out-of-resource allocation, which could be handled by a CRASH() macro.

> > Source/WebCore/platform/graphics/gpu/opencl/FilterContextOpenCL.h:32
> > +#include "CL/cl.h"
> 
> On OS X This is under <OpenCL/cl.h>

Mac port comes later.

> 
> > Source/WebCore/platform/graphics/gpu/opencl/FilterContextOpenCL.h:104
> > +            {
> > +                clFinish(m_context->m_commandQueue);
> > +                clEnqueueNDRangeKernel(m_context->m_commandQueue, m_kernel, 2, 0, m_globalSize, 0, 0, 0, 0);
> > +            }
> 
> These should really be checked. These are pretty likely to fail.

Why?

> Where do you wait for the kernel to complete? The only clFinish/clWaitForEvents I see is before a clEnqueueNDRangeKernel

Opencl supports async execution, so we don't need to wait here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.