[Webkit-unassigned] [Bug 103101] New: [CMake] Allow user specified compiler flags to take precedence

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103101

           Summary: [CMake] Allow user specified compiler flags to take
                    precedence
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: laszlo.gombos at webkit.org


Compiler/linker flags (e.g. CMAKE_C_FLAGS, CMAKE_CXX_FLAGS, CMAKE_SHARED_LINKER_FLAGS) specified by the build system should be always prepended to the user specified flags to make sure that the user specified flags take precedence.

As an example - for the efl port - if the user would specify "build-webkit --efl --cmakearg="-DCMAKE_CXX_FLAGS=-Werror=unused-parameter" to treat unused-parameter warnings as errors, it would not work because the gcc command line would look something like the following:

"... --Werror=unused-parameter ... -Werror -Wno-error=unused-parameter" and -Wno-error=unused-parameter takes precedence and the user specified option is ignored.

This is also an attempt to not only fix this bug, but also make the code more consistent by always prepending compiler/linker flags in cmake files (as sometimes the code appends, sometimes prepends currently).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.