[Webkit-unassigned] [Bug 103088] Remove SVGShadowText
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 22 14:15:26 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103088
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #175709|review? |review+
Flag| |
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> 2012-11-22 14:17:29 PST ---
(From update of attachment 175709)
View in context: https://bugs.webkit.org/attachment.cgi?id=175709&action=review
> Source/WebCore/dom/Text.cpp:242
> +static bool isSVGShadowText(Text* text)
I would add inline if I were you.
> Source/WebCore/dom/Text.cpp:248
> +static bool isSVGText(Text* text)
Ditto.
> Source/WebCore/svg/SVGTRefElement.cpp:162
> root->firstChild()->setTextContent(textContent, ASSERT_NO_EXCEPTION);
We should probably assert that firstChild is a Text node.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list