[Webkit-unassigned] [Bug 103060] Eliminate EditingText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103060


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175666|review?                     |review+
               Flag|                            |




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2012-11-22 08:40:58 PST ---
(From update of attachment 175666)
View in context: https://bugs.webkit.org/attachment.cgi?id=175666&action=review

> Source/WebCore/dom/Node.h:320
> +    bool hasName() const { ASSERT(!isTextNode()); return getFlag(HasNameOrIsEditingTextFlag); }

These two statements should probably be put in separate lines.

> Source/WebCore/dom/Node.h:334
> +    bool isEditingText() const { ASSERT(isTextNode()); return getFlag(HasNameOrIsEditingTextFlag); }

Ditto.

> Source/WebCore/dom/Node.h:336
> +    void setHasName(bool f) { ASSERT(!isTextNode()); setFlag(f, HasNameOrIsEditingTextFlag); }

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.