[Webkit-unassigned] [Bug 99829] OpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99829


Peter Gal <galpeter at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |galpeter at inf.u-szeged.hu




--- Comment #12 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-11-22 05:04:59 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=175437&action=review

> Source/WebCore/Target.pri:4091
> +    HEADERS += platform/graphics/gpu/opencl/OpenCLHandle.h
> +    HEADERS += platform/graphics/gpu/opencl/FilterContextOpenCL.h
> +    SOURCES += platform/graphics/gpu/opencl/FilterContextOpenCL.cpp
> +    SOURCES += platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp
> +    SOURCES += platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp
> +    SOURCES += platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp

+= for all files looks a little overkill. You could use something like this (like in any other place):

HEADERS += .../OpenCLHandle.h \
           .../Filter...

and same for the SOURCES

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.