[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #11 from Jongseok Yang <js45.yang at samsung.com>  2012-11-22 01:23:08 PST ---
(In reply to comment #8)
> (In reply to comment #4)
> > (From update of attachment 175563 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=175563&action=review
> > 
> > >> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
> > >> +                break;
> > > 
> > > The locking scope should be specified. If WorkQueue::invalidate() is called while workItemQueue[i]();, there will be lockup.
> > > 
> > > {
> > >     MutexLocker locker(m_isValidMutex);
> > >     if (!m_isValid)
> > >         break;
> > > }
> > 
> > I agree with Byungwoo. Also, wouldn't it make sense to return instead of break is m_isValid is false?
> Yes, good point. I also think that 'return' is better.

Ok, I fixed that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.