[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 00:28:49 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #6 from Jongseok Yang <js45.yang at samsung.com>  2012-11-22 00:30:50 PST ---
(In reply to comment #3)
> > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:64
> > void WorkQueue::platformInvalidate()
> > {
> How about adding code to clear m_workItemQueue and m_timerWorkItems in the platformInvalidate()?
> This also can prevent redundant looping in performXXX function.

Actually, I'm not sure the work of the function.
How about making new patch for this function?
I hope that my patch is just for "m_isValid".

> 
> > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:163
> >         // If a timer work item expired, dispatch the function of the work item.
> >         timerWorkItems[i]->dispatch();
> performTimerWork() function have same issue. How about adding the same check code here?

It's good. It is my missing point. Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list