[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 00:22:38 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #5 from Jongseok Yang <js45.yang at samsung.com>  2012-11-22 00:24:40 PST ---
(In reply to comment #2)
> (From update of attachment 175563 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175563&action=review
> 
> > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
> > +            MutexLocker locker(m_isValidMutex);
> > +            if (!m_isValid)
> > +                break;
> 
> The locking scope should be specified. If WorkQueue::invalidate() is called while workItemQueue[i]();, there will be lockup.
> 
> {
>     MutexLocker locker(m_isValidMutex);
>     if (!m_isValid)
>         break;
> }

You're right. I'll fix it/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list