[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853





--- Comment #4 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-11-21 17:55:25 PST ---
(From update of attachment 175316)
View in context: https://bugs.webkit.org/attachment.cgi?id=175316&action=review

>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:29
>>> +#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
>> 
>> unneeded include. Already included in EWK2UnitTestBase.h.
> 
> ?

I refactored EWK2UnitTestBase.h to include the EWK2UnitTestEnvironment.h, Ecore.h, Eina.h headers in http://trac.webkit.org/changeset/135349, as they are used commonly in API test cases.
Actually, I started this work as I have been pointed out that why <gtest/gtest.h> should be included in the test files even though it is already included in EWK2UnitTestBase.h file. Then according to Laszlo's comments, I moved out the duplicated headers in to EWK2UnitTestBase.h.

>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:53
>>> +    ASSERT_EQ(applicationCacheManager, ewk_context_application_cache_manager_get(context));
>> 
>> This comparison seems to be meaningless.
> 
> It is not meaningless, it makes sure we return the same pointer every time. This is consistent with our other tests.

I got it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.