[Webkit-unassigned] [Bug 102552] IndexedDB: Obtain ScriptState from IDL binding generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102552





--- Comment #9 from Joshua Bell <jsbell at chromium.org>  2012-11-21 16:21:15 PST ---
(From update of attachment 175501)
View in context: https://bugs.webkit.org/attachment.cgi?id=175501&action=review

IDB changes LGTM but would be nice to start off with consistent naming, i.e....

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:136
> +    return put(IDBObjectStoreBackendInterface::AddOrUpdate, IDBAny::create(this), scriptState, value, key, ec);

^^^ "scriptState" vs.

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:139
> +PassRefPtr<IDBRequest> IDBObjectStore::put(IDBObjectStoreBackendInterface::PutMode putMode, PassRefPtr<IDBAny> source, ScriptState* state, ScriptValue& value, PassRefPtr<IDBKey> prpKey, ExceptionCode& ec)

^^^ "state"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.