[Webkit-unassigned] [Bug 102961] New: IndexedDB: Remove IDBDatabaseException.idl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 10:28:59 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102961

           Summary: IndexedDB: Remove IDBDatabaseException.idl
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jsbell at chromium.org
                CC: abarth at webkit.org, arv at chromium.org,
                    dgrogan at chromium.org, alecflett at chromium.org
        Depends on: 98050,102514,102726


See wkbug.com/102514 for more history, but:

* IDBDatabaseException is no longer exposed to script
* IDBDatabaseException.idl has not been deleted:

DOMExceptions are thrown by using an ExceptionCode to look up an ExceptionCodeDescription which provides name/code/message for the DOMException. This is done via a generated file c/o dom/make_dom_exceptions.pl which processes DOMExceptions.in and makes calls to each listed exception type to allow it to try and decode the ExceptionCode and return an ExceptionCodeDescription. IDBDatabaseException.cpp implements this for IDB-specific exception types, even though they are not instances of an IDBDatabaseException. So without rewriting the DOMException code we need to keep IDBDatabaseException listed in DOMExceptions.in

However, the DOMExceptions.in is also used to generate headers used in the binding code - specifically, setDOMException (JSC and V8 variants). Those headers rely on a V8<blah>.h / JS<blah>.h file existing, which is generated off the IDL. So if we have IDBDatabaseEception listed in DOMExceptions.in we need to keep IDBDatabaseException.idl around even though it's not used.

...

The "real" fix is probably to do wkbug.com/102726 and possibly wkbug.com/98050 first, and make the means by which an ExceptionCodeDescription is populated a little smarter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list