[Webkit-unassigned] [Bug 98857] [Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98857





--- Comment #18 from Filip Pizlo <fpizlo at apple.com>  2012-11-21 02:37:02 PST ---
(From update of attachment 173263)
I don't particularly like this fix.  First, it's masking the problem that relink() is assuming that something is a blx when it's actually a bne.  Second, if you really want to disable patching of get_by_val/put_by_val then you should do it without preprocessor macros in the JIT's code.  That's just ugly and error-prone.

I strongly recommend that you do the *really simple* fix of making relink() work with bne, or making patchableBranch32() emit a blx.

But I will defer to Zoltan's opinion on this.  Zoltan, do you think that what I'm suggesting is sensible?  Or do you feel strongly that we should land this workaround as-is?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.