[Webkit-unassigned] [Bug 102907] New: TargetFrame and innerNodeFrame confused

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 02:24:35 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102907

           Summary: TargetFrame and innerNodeFrame confused
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: allan.jensen at digia.com
        Depends on: 98139


While trying to clarify the point returned by HitTestResult, I have gone through all the call-sites using the point, and have noticed what I can only assume are errors in webkithittestresult.cpp.

First of all you use targetFrame instead of the frame of the innernode to translate to window coordinates. This is likely wrong since targetframe is the frame the link your are hovering will be opened in (open link in different frame/open link in new window feature). 

Secondly your fall-back logic while probably not necessary uses the point in innerNodeFrame, it should probably instead use the point in mainFrame instead and translate from the mainframe. Alternatively you can always translate from the main-frame coordinates once the patch for bug #98139 lands.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list