[Webkit-unassigned] [Bug 102817] Reset the slider thumb location before every layout of the slider container

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102817





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-21 02:14:49 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 175231 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=175231&action=review
> 
> Thanks for reviewing.
> 
> > > Source/WebCore/html/shadow/SliderThumbElement.cpp:185
> > > +    if (input->sliderThumbElement() && input->sliderThumbElement()->renderer()) {
> > > +        thumb = toRenderBox(input->sliderThumbElement()->renderer());
> > > +        // Reset the thumb location before layout.
> > > +        thumb->setLocation(LayoutPoint());
> > > +    }
> > 
> > When we call thumbLocation.setX, can we set the position to offset rather than adding in the old position?
> 
> Yes, I think so, I'll try

The initial position of the thumb slider is set by the parent container in RenderBlock::layoutBlockChild() and it depends on the padding, border and margin. I don't know if the thumb can be affected by those, because after the layoutBlockChild() the thumb position is always 0. In case of being greater than 0 I guess it makes sense to add the offset, but I guess we should also use the current thumb position when the container is not laid out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.