[Webkit-unassigned] [Bug 102687] [EFL] GLX detection is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102687





--- Comment #11 from Kalyan <kalyan.kondapally at intel.com>  2012-11-20 18:14:06 PST ---
(In reply to comment #9)
> (From update of attachment 175240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175240&action=review
> 
> I need your input to my comment #8 to properly comment on your new Find-file, but a few things should be improved regardless of that:
>  o It needs some documentation at the top like the other Find-files.
>  o We use a 4-space indentation style instead of a 2-space one.
>  o The `X11_FOUND' check implicitly assumes FindX11.cmake was already called before, which is not always the case. Since you do not include X11 headers or link against any X11 library in your CHECK_C_SOURCE_COMPILES_CALL(), it might be worth simply not checking for `X11_FOUND' at all.
>  o "YES" (a string) is different from YES (a boolean). Either way, we normally use FindPackageHandleStandardArguments() to set that, since it also handles other Find-module arguments such as QUIET and the like.
> 
> > Source/cmake/OptionsEfl.cmake:161
> > +  FIND_PACKAGE(OpenGLX)
> > +
> > +  IF (OPENGLX_FOUND)
> > +    ADD_DEFINITIONS(-DHAVE_GLX)
> > +  ENDIF()
> 
> Do the tiled backing store and WebGL still work if the GLX is not found?
:
Current Situation: No. 

Once these things are fixed for GLX we need to add support for EGL. Than we need some kind of mechanism to configure what back end we would like to use(GLX or EGL or something else ?). I see we already have support for configuration flags like --enable-egl , --enable--glx and so on. Probably we can investigate more on this front when we start adding support for EGL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.