[Webkit-unassigned] [Bug 102764] Use m_webView->size() for viewport update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102764





--- Comment #7 from Tien-Ren Chen <trchen at chromium.org>  2012-11-20 17:24:59 PST ---
(In reply to comment #3)
> (From update of attachment 175130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175130&action=review
> 
> I think the general concept here is good, but I think there is relatively weak evidence that this won't have unexpected changes in behavior.
> 
> > Source/WebKit/chromium/ChangeLog:12
> > +        rendering purpose.
> 
> While the intent of this change seems good, it seems scary to apply such a modification without at least identifying some test cases that cover this behavior. From the sound of the bug, it should be possible to construct a test case illustrating the case of a pending resize that should not be used for the current rendering.

I just added some debug output to RenderWidget::setWindowRect and RenderWidget::OnResize. I think it is very wrong to use windowRect in the first place.

The semantics of windowRect is the outer rect of the window, that is, including all decorations like the title bar, status bar, navigation buttons and such. I don't think it makes any sense to use it for layout purpose.

(In reply to comment #6)
> (From update of attachment 175130 [details])
> Can you add a test?

Instead of adding tests, I think we should modify all tests in WebFrameTest to remove the windowRect() override in WebViewClient implementations. The tests should still work without windowRect().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.