[Webkit-unassigned] [Bug 102827] [CMake] Optimize binary size by removing dead sections on unix/gcc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102827





--- Comment #4 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-11-20 15:00:15 PST ---
(In reply to comment #3)
> (From update of attachment 175257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175257&action=review

> > Source/cmake/OptionsCommon.cmake:37
> > +IF (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
> 
> This is similar to the check we have in the WEBKIT_SET_EXTRA_COMPILER_FLAGS macro, so I wonder why this was not just put there.

I am not quite sure what is the best way to determine which rule goes to WebKitHelpers.cmake and OptionsCommon.cmake. OptionsCommon.cmake has similar rules as well (see for example the rule to set no-keep-memory linker flag in certain conditions.

Should I move the "no-keep-memory linker flag" to WebKitHelpers.cmake as well ?

It would be great to add a few lines description to each file to help to understand what goes where.

I will reflect on your other comments once I have some data. Thanks for the help.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.