[Webkit-unassigned] [Bug 102787] [Qt][Win] Fix the build after r135217

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102787





--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2012-11-20 14:15:00 PST ---
It looks like this is happening on the Qt-WIn build bot because it is using the SDK v7.0A, rather than the older "Windows Server 2003 R2 Platform SDK" documented in the Windows build instructions.

The culprit seems to be that the <ObjBase.h> header file is not getting included automatically by the include of <Shlwapi.h>.  <ObjBase.h> includes the definition for DECLARE_INTERFACE_IID_, which is the macro that is causing the problem.

It looks like NOSHLWAPI is somehow getting defined in the Qt build (or maybe is also defined under the other Windows builds, but we don't see the problem because we are using a different version of the header).

It looks like other examples of using <Shlwapi.h> are done like so (in other program source bases):

#undef NOSHLWAPI
#include <shlwapi.h>

I am going to try to check this in (once the never-ending Layouttest update finishes) and see if it fixes the problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.