[Webkit-unassigned] [Bug 102817] Reset the slider thumb location before every layout of the slider container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 10:33:54 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102817





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-20 10:35:53 PST ---
(In reply to comment #2)
> (From update of attachment 175231 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175231&action=review

Thanks for reviewing.

> > Source/WebCore/html/shadow/SliderThumbElement.cpp:185
> > +    if (input->sliderThumbElement() && input->sliderThumbElement()->renderer()) {
> > +        thumb = toRenderBox(input->sliderThumbElement()->renderer());
> > +        // Reset the thumb location before layout.
> > +        thumb->setLocation(LayoutPoint());
> > +    }
> 
> When we call thumbLocation.setX, can we set the position to offset rather than adding in the old position?

Yes, I think so, I'll try

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list