[Webkit-unassigned] [Bug 102817] Reset the slider thumb location before every layout of the slider container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 10:15:34 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102817


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175231|review?                     |review+
               Flag|                            |




--- Comment #2 from Tony Chang <tony at chromium.org>  2012-11-20 10:17:33 PST ---
(From update of attachment 175231)
View in context: https://bugs.webkit.org/attachment.cgi?id=175231&action=review

> Source/WebCore/html/shadow/SliderThumbElement.cpp:185
> +    if (input->sliderThumbElement() && input->sliderThumbElement()->renderer()) {
> +        thumb = toRenderBox(input->sliderThumbElement()->renderer());
> +        // Reset the thumb location before layout.
> +        thumb->setLocation(LayoutPoint());
> +    }

When we call thumbLocation.setX, can we set the position to offset rather than adding in the old position?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list