[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 09:47:10 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=96637


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175227|review?                     |review+
               Flag|                            |




--- Comment #48 from Adam Barth <abarth at webkit.org>  2012-11-20 09:49:08 PST ---
(From update of attachment 175227)
View in context: https://bugs.webkit.org/attachment.cgi?id=175227&action=review

Very nice.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:58
> +

By the way, is there a reason we have:

class DOMWrapperWorld : public WTF::RefCountedBase

The normal pattern is

class DOMWrapperWorld : public RefCounted<DOMWrapperWorld>

Sorry if I asked you that before and forgot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list