[Webkit-unassigned] [Bug 102687] [EFL] GLX detection is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102687





--- Comment #5 from Kalyan <kalyan.kondapally at intel.com>  2012-11-20 09:43:25 PST ---
(In reply to comment #3)
> (From update of attachment 175076 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review
> 
> > Source/cmake/OptionsEfl.cmake:190
> > +include(CheckCSourceCompiles)
> > +include(CheckCXXSourceCompiles)
> 
> Coding style: our CMake calls are all uppercased.
> 
> > Source/cmake/OptionsEfl.cmake:200
> > +CHECK_C_SOURCE_COMPILES(
> > +"
> > +#include <GL/glx.h>
> > +int main()
> > +{
> > +    GLXFBConfig c;
> > +    return 0;
> > +}
> > +"
> > +GLXCOMPILATIONPASSED)
> 
> Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL).

This assumption would be wrong on some platforms i.e wayland.

> > Source/cmake/OptionsEfl.cmake:203
> > +    SET(HAVE_GLX 1)
> 
> This does not seem to be used anywhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.