[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90968





--- Comment #32 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-11-20 06:46:21 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=175201&action=review

> Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:75
> +            result.timeout = atoi(timeoutToken.c_str());

atoi return int here, but in the WRT atof is used. So should be use int or float/double. I see no reason to use float/double since int was used before and also who would give 3.5 (in ms) as a timeout value.

(I should've seen this before)

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:724
> +    setTimeout(command.timeout);

You removed the 'if (timeout > 0)' check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.