[Webkit-unassigned] [Bug 101291] [EFL] Refactor GraphicsContext3DEFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101291





--- Comment #53 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-11-20 00:42:28 PST ---
(In reply to comment #52)
t());

> Sorry, I didnt check this properly before. This is completely wrong. We need to first make the context current before checking the status(if we have a valid context or not). 
> so basically it goes as follows:
> 1)Make the context current with the given surface.    i.e. m_platformContext->makeCurrent(m_platformSurface.get())
> 2)Check if the first step succeeded and we still have a valid context.
> 3)return true if the above two conditions are met else false
> 
> If the changes are done in PlatformContext(as discussed above to return isValid()), then steps 1 and 2 are merged into one.
> 
> Than we have something like:
> bool GraphicsContext3DPrivate::makeContextCurrent()
> {
>     bool success = m_platformContext->makeCurrent(m_platformSurface.get());
> 
>     if (!success && m_contextLostCallback) {
>         m_contextLostCallback->onContextLost();
>         // FIXME: Restore context
>     }
> 
>     return success;
> }

Yes, this code make sense now. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.