[Webkit-unassigned] [Bug 101291] [EFL] Refactor GraphicsContext3DEFL
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 19 16:30:20 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=101291
--- Comment #47 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2012-11-19 16:32:16 PST ---
(From update of attachment 174840)
View in context: https://bugs.webkit.org/attachment.cgi?id=174840&action=review
> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:51
> + if (!m_platformContext)
Two spaces in "if (!m_"
> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:113
> + bool returnValue = m_platformContext->makeCurrent(m_platformSurface.get());
Why do you use local variable here? Is below example more clear? I wonder if there is any reason.
if (m_contextLostCallback && !m_platformContext->isValid()) {
m_contextLostCallback->onContextLost();
return false;
}
return m_platformContext->makeCurrent(m_platformSurface.get());
> Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:107
> + m_contextLost = false;
I think 127 line is more proper place for this.
> Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:117
> + bool returnValue = false;
If possible, I think we should not use local variable for return.
> Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:122
> + returnValue = true;
Can't we return here ? Because, it looks there is no process related to this logic below.
> Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:125
> + returnValue = true;
ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list