[Webkit-unassigned] [Bug 100061] [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100061





--- Comment #21 from Tien-Ren Chen <trchen at chromium.org>  2012-11-19 15:53:23 PST ---
(In reply to comment #20)
> (From update of attachment 174796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174796&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:4349
> > +bool WebViewImpl::shouldApplyDeviceScaleFactorInCompositor() const
> > +{
> > +    return m_webSettings->applyDeviceScaleFactorInCompositor();
> > +}
> 
> I don't really understand the point of this function.  Why don't callers just get the information from the settings themselves?  We don't want to create these sorts of accessors for every setting...

I can only get WebSettings but not WebSettingsImpl from the outside of WebViewImpl. :(

The options are:
1. Create an accessor on WebViewImpl.
2. Make WebViewImpl::settingsImpl() public.
3. Add virtual getters on WebSettings.
4. Passing it as an argument to WebPagePopupImpl::create

Which solution you think is the best?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.