[Webkit-unassigned] [Bug 101346] [BlackBerry] No condition present to check if Compressed Texture S3TC extension support exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101346





--- Comment #13 from Yong Li <yoli at rim.com>  2012-11-19 12:50:00 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> We're not sure about the string that's being used to check whether s3tc is supported or not. We are using this website (http://www.opengl.org/registry/specs/EXT/texture_compression_s3tc.txt) as our basis for the string being passed in, but we're not a 100% sure and don't want other platforms to suffer because of this. 
> 

If a platform does support GL_EXT_texture_compression_s3tc but Extensions3D::supports(GL_EXT_texture_compression_s3tc) returns false, I would think it is a bug in that port, and should be fixed by people who maintain that port.

I think this is actually a cross-platform fix. Can you create a layout-test and also get WebGL reviewers involved?

class Extensions3D {
public:
    virtual ~Extensions3D() {}

    // Supported extensions:
    //   GL_EXT_texture_format_BGRA8888
    //   GL_EXT_read_format_bgra
    //   GL_ARB_robustness
    //   GL_ARB_texture_non_power_of_two / GL_OES_texture_npot
    //   GL_EXT_packed_depth_stencil / GL_OES_packed_depth_stencil
    //   GL_ANGLE_framebuffer_blit / GL_ANGLE_framebuffer_multisample
    //   GL_OES_texture_float
    //   GL_OES_standard_derivatives
    //   GL_OES_rgb8_rgba8
    //   GL_OES_vertex_array_object
    //   GL_ANGLE_translated_shader_source
    //   GL_ARB_texture_rectangle (only the subset required to
    //     implement IOSurface binding; it's recommended to support
    //     this only on Mac OS X to limit the amount of code dependent
    //     on this extension)
    //   GL_EXT_texture_compression_dxt1
    //   GL_EXT_texture_compression_s3tc
    //   GL_OES_compressed_ETC1_RGB8_texture
    //   GL_IMG_texture_compression_pvrtc
    //   EXT_texture_filter_anisotropic
    //   GL_EXT_debug_marker
    //   GL_CHROMIUM_copy_texture
    //   GL_CHROMIUM_flipy

    // Takes full name of extension; for example,
    // "GL_EXT_texture_format_BGRA8888".
    virtual bool supports(const String&) = 0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.