[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 03:52:53 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101857





--- Comment #23 from Aivo Paas <aivopaas at gmail.com>  2012-11-19 03:54:49 PST ---
(In reply to comment #22)
> (In reply to comment #20)
> > (In reply to comment #19)
> > > (From update of attachment 174920 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=174920&action=review
> > > 
> > > > Source/WebCore/rendering/RenderObject.cpp:1809
> > > > +    if (oldStyle.get() && !areCursorsEqual(oldStyle.get(), this->style())) {
> > > > +        if (Frame* frame = this->frame())
> > > > +            frame->eventHandler()->updateCursor();
> > > > +    }
> > > > +
> > > 
> > > Would there be a problem in only updating the cursor when node is hovered?
> > 
> > I think that would be great. Is there a flag set when a node is hovered?
> 
> Yes, check Node::hovered().

Tried that, didn't work. Broke tests, probably related to text nodes, because those don't seem to get the hovered flag set. This optimization opportunity should be investigated in another bug, it's going out of the scope of this bug / patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list