[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101857





--- Comment #15 from Aivo Paas <aivopaas at gmail.com>  2012-11-16 14:13:09 PST ---
(In reply to comment #14)
> (From update of attachment 174755 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174755&action=review
> 
> > Source/WebCore/rendering/RenderObject.cpp:1808
> > +    if (oldStyle.get() && !areCursorsEqual(oldStyle.get(), this->style())) {
> > +        if (Frame* frame = this->frame())
> > +            frame->eventHandler()->updateCursor();
> > +    }
> 
> Why move this to setStyle instead of styleDidChange?

That's already explained in the changelog.
I spotted strange behaviour on mousedown/up on text node vs no text node. Over text node the logic in EventHandler didn't pick up the correct cursor in the first pass. My guess is that something in the StyleDidChange caused the textnode to update after the updateCursor() call was made. So, to be sure that all the things that happen inside StyleDidChange do not affect wether or not cursor gets updated, I moved it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.