[Webkit-unassigned] [Bug 101748] [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility implementation with other WebKit ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101748





--- Comment #17 from Krzysztof Czech <k.czech at samsung.com>  2012-11-16 03:38:21 PST ---
(In reply to comment #14)
> (From update of attachment 174168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174168&action=review
> 
> > Source/WebKit2/GNUmakefile.list.am:1148
> > +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.h \
> > +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp \
> 
> It seems to maintain the alphabetical ordering, these should go above Source/WebKit2/WebProcess/WebPage/gtk/WebInspectorGtk.cpp.
Done.
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:33
> > +#include "WebPageAccessibilityObjectAtk.h"
> 
> It makes sense to keep the header name as WebPageAccessibilityObject.h since that's the name of GObject.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.