[Webkit-unassigned] [Bug 102452] Plumbing showPaintRects out of InspectorPageAgent to use a different drawing implementation if available.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102452





--- Comment #2 from egraether at chromium.org  2012-11-15 18:18:24 PST ---
(From update of attachment 174580)
View in context: https://bugs.webkit.org/attachment.cgi?id=174580&action=review

To make the showPaintRects checkbox in the Web Inspector's settings activate the paint rects in the HUDLayer, I implemented a similar plumbing than the one that was used for showFPSCounter.

> Source/WebCore/inspector/InspectorPageAgent.cpp:902
> +    if (!m_enabled || !m_state->getBoolean(PageAgentState::showPaintRects) || m_client->canShowPaintRects())

This extra check disables the painting of the paint rects into the InspectorOverlay.

> Source/WebKit/chromium/src/WebViewImpl.cpp:838
> +        return page()->settings()->forceCompositingMode();

This time a good check if the HUDLayer can draw the paint rects is necessary, because the fallback to the software paint rects needs to work. This check is the best I found so far, but it's value can change when page switches happen. This causes the paint rects then to switch between software and GPU rendering.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.