[Webkit-unassigned] [Bug 102436] New: [BlackBerry] Fix assert in NetworkJob::notifyAuthReceived

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 14:45:05 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102436

           Summary: [BlackBerry] Fix assert in
                    NetworkJob::notifyAuthReceived
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jmason at rim.com


// The scheme might have changed, but the server type shouldn't have!
BLACKBERRY_ASSERT(serverType == oldSpace.serverType());

That comment is wrong - the server type could change if we contact a site taking HTTP auth, through an HTTP proxy taking auth of its own. First we get a 407 from the proxy, and then when get passed the proxy, we get a 401 from the end site - so notifyAuthReceived gets called again with auth type Proxy instead of HTTP.

The correct thing to do when that happens is skip the "update the auth type in the credentials" step, since these are actually new credentials and not just credentials being reused for a different auth type on the same server.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list