[Webkit-unassigned] [Bug 102431] New: Bad style complaint about header in test file
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 14:24:37 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=102431
Summary: Bad style complaint about header in test file
Product: WebKit
Version: 528+ (Nightly build)
Platform: Other
OS/Version: Other
Status: NEW
Severity: Minor
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: ericu at chromium.org
Attachment 174514 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/tests/ChromeClientImplTest.cpp:35: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 4 files
Here are the headers:
#include "config.h"
#include <gtest/gtest.h>
#include "Chrome.h"
#include "WebFrameClient.h"
#include "WebInputEvent.h"
#include "WebView.h"
#include "WebViewClient.h"
#include "WebViewImpl.h"
There is no "header this file implements", as this is a test file, so I'm not sure which part is really confusing it.
Line 35 is the #include of "Chrome.h".
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list