[Webkit-unassigned] [Bug 101748] [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility implementation with other WebKit ports.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 09:42:31 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101748


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174168|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2012-11-15 09:44:19 PST ---
(From update of attachment 174168)
View in context: https://bugs.webkit.org/attachment.cgi?id=174168&action=review

> Source/WebKit2/GNUmakefile.list.am:1148
> +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.h \
> +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp \

It seems to maintain the alphabetical ordering, these should go above Source/WebKit2/WebProcess/WebPage/gtk/WebInspectorGtk.cpp.

> Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:33
> +#include "WebPageAccessibilityObjectAtk.h"

It makes sense to keep the header name as WebPageAccessibilityObject.h since that's the name of GObject.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list