[Webkit-unassigned] [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101910


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174369|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2012-11-15 06:03:49 PST ---
(From update of attachment 174369)
View in context: https://bugs.webkit.org/attachment.cgi?id=174369&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:888
> +                    contentHelper._appendTextRow(WebInspector.UIString("Details"), this.detailsNode().childNodes[1].textContent);

So this is a third time I am suggesting to call appendElementRow here :) Is there a reason why this is bad?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1006
> +        if (!details)

You don't need this check now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.