[Webkit-unassigned] [Bug 102346] Fix incomplete holding lock on accessing m_completeDatabasePath

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102346





--- Comment #4 from Changhyup Jwa <ch.jwa at samsung.com>  2012-11-15 03:58:08 PST ---
(From update of attachment 174366)
View in context: https://bugs.webkit.org/attachment.cgi?id=174366&action=review

>> Source/WebCore/ChangeLog:10
>> +        holding m_syncLock.
> 
> Any test case ?

There's no change on WebKit's functionality on this patch, I just move the lines inside mutex lock(hold m_syncLock).

m_completeDatabasePath is a shared resource between the 2 threads(main and IconDatabase::iconDatabaseSyncThread).

So, it should be accessed with holding m_syncLock.

But below lines are accessing m_completeDatabasePath without holding this.

Therefore I just modified those lines with holding m_syncLock, with no functional change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.