[Webkit-unassigned] [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101910





--- Comment #10 from pdeng6 <pan.deng at intel.com>  2012-11-14 03:38:29 PST ---
(In reply to comment #8)
> (From update of attachment 173890 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173890&action=review
> 
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:930
> > +        if (details && details.hasOwnProperty('textContent'))
> 
> You should check for (details instanceof Node) and then use textContent.
> 
> But as Eugene mentioned, the fact that details() returns either string or Node is the root of the problem. I'd rename details() to detailsNode() and create a span with text in case of text content there. Then I would use detailsNode.textContent in testContentMatching and removed the similar type check from WebInspector.TimelineRecordListRow.prototype.update + would also use appendElementRow in _generatePopupContentWithImagePreview.

Good point, thanks, Done!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.