[Webkit-unassigned] [Bug 100851] [V8] use toV8Fast in all relevant Node getters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 01:18:44 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=100851





--- Comment #13 from Kentaro Hara <haraken at chromium.org>  2012-11-14 01:20:31 PST ---
(From update of attachment 174099)
View in context: https://bugs.webkit.org/attachment.cgi?id=174099&action=review

Looks good to me as an incremental step to implement toV8Fast() and kill toV8Slow().

Just to clarify, would you explain what code will be executed for HTMLDivElement::toV8Fast() by this change?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:606
> +        V8DOMWindowShell* context = V8DOMWindowShell::getEntered();
> +        ASSERT(context);
> +        v8::Handle<v8::Object> wrapper = context->world()->isolatedWorldDOMDataStore()->get(impl);

Consider a change from abarth (https://bugs.webkit.org/show_bug.cgi?id=102156).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list