[Webkit-unassigned] [Bug 101192] [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 07:50:04 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101192





--- Comment #12 from Mihai Maerean <mmaerean at adobe.com>  2012-11-13 07:51:49 PST ---
(In reply to comment #6)
> Why not just have Chromium use WebSettings to enable Regions?

chromium/src/content/renderer/render_thread_impl.cc uses WebRuntimeFeatures and RuntimeEnabledFeatures to enable similar features:

void RenderThreadImpl::EnsureWebKitInitialized() {
...
  WebRuntimeFeatures::enableStyleScoped(command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures));
  WebRuntimeFeatures::enableCSSExclusions(command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures));

The idea was to use switches::kEnableExperimentalWebKitFeatures in a way that is similar to how it has been used before.

Using WebSettings would be nice because it would have a direct connection with WebCore::Settings.

Unfortunately, there is no mention of WebSettings inside chromium/src/content/renderer/render_thread_impl.cc .

How should I get access to WebSettings from inside render_thread_impl.cc?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list