[Webkit-unassigned] [Bug 102070] New: Some Perf tests fail due to output text parse error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 04:44:18 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102070

           Summary: Some Perf tests fail due to output text parse error
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.7
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pravind.2k4 at gmail.com
                CC: jchaffraix at webkit.org, rniwa at webkit.org


Created an attachment (id=173864)
 --> (https://bugs.webkit.org/attachment.cgi?id=173864&action=review)
Failing Testcase

Description : When some perf tests run using ./Tools/Scripts/run-perf-tests , fail with the following msg
$./Tools/Scripts/run-perf-tests PerformanceTests/reattach/abs_to_static_inline_inline.html
Running 1 tests
Running reattach/abs_to_static_inline_inline.html (1 of 1)
 Running 20 times
FAILED
Finished: 47.007584 s

Even though the test has run successfully, the result is not published to PerformanceTestsResults.json due to the above failure.

The reason is that is some cases the output.text in being parsed in parse_output() in Tools/Scripts/webkitpy/perftest.py contains a leading space.

parse_output() calls _should_ignore_line_in_parser_test_result() which in turn uses a list "_lines_to_ignore_in_parser_result" to check if the line has to ignored or not. 
As _lines_to_ignore_in_parser_result does not expect a line with leading/trailing spaces , _should_ignore_line_in_parser_test_result() fails which results in the parse_output() assuming
that an error has occured.

Attaching the perf test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list